globals
Validates against assignment/mutation of globals during render, part of ensuring that side effects must run outside of render.
This is an evaluation implementation and may contain false positives or negatives that have not yet been fully audited. Review each report carefully before applying fixes.
Full Name in eslint-plugin-react-x@rc
react-x/globalsFull Name in @eslint-react/eslint-plugin@rc
@eslint-react/globalsFeatures
๐งช
Rule Details
Global variables exist outside React's control. When you modify them during render, you break React's assumption that rendering is pure. This can cause components to behave differently in development vs production, break Fast Refresh, and make your app impossible to optimize with features like React Compiler.
Common Violations
Invalid
// โ Global counter
let renderCount = 0;
function Component() {
renderCount++; // Mutating global
return <div>Count: {renderCount}</div>;
}// โ Modifying window properties
function Component({ userId }) {
window.currentUser = userId; // Global mutation
return <div>User: {userId}</div>;
}// โ Global array push
const events = [];
function Component({ event }) {
events.push(event); // Mutating global array
return <div>Events: {events.length}</div>;
}// โ Cache manipulation
const cache = {};
function Component({ id }) {
if (!cache[id]) {
cache[id] = fetchData(id); // Modifying cache during render
}
return <div>{cache[id]}</div>;
}Valid
// โ
Use state for counters
function Component() {
const [clickCount, setClickCount] = useState(0);
const handleClick = () => {
setClickCount(c => c + 1);
};
return (
<button onClick={handleClick}>
Clicked: {clickCount} times
</button>
);
}// โ
Use context for global values
function Component() {
const user = useContext(UserContext);
return <div>User: {user.id}</div>;
}// โ
Synchronize external state with React
function Component({ title }) {
useEffect(() => {
document.title = title; // OK in effect
}, [title]);
return <div>Page: {title}</div>;
}